Skip to content

Commit

Permalink
Remove generic column classes and replace with new .has-gutter class
Browse files Browse the repository at this point in the history
  • Loading branch information
trevanhetzel committed Sep 15, 2014
1 parent b5ef1f5 commit 6b3b0db
Show file tree
Hide file tree
Showing 5 changed files with 43 additions and 40 deletions.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@

#### Breaking Changes

* **Grid class names have changed**

Previously, BareKit was using some very generic selectors to select all elements that start with `sm`, `md` and `lg` and give them some box model properties (`float` and `padding`). This caused some trouble, so I decided to separate out those box model properties to their own new class: `has-gutter`. This way, you can still use classes like `sm-6` for widths, but aren't tied down to the padding and float if you don't want to be.

So if you want to still use the "grid" (not just the width classes), a line that previously looked like this:

```
<div class="sm-12 md-6 lg-1" style="background: #e1e1e1">1</div>
```

will now need to look like this:

```
<div class="sm-12 md-6 lg-1 has-gutter" style="background: #e1e1e1">1</div>
```

* **Off-canvas class names have changed** ([52a76560](https://github.com/a2labs/barekit/commit/52a7656034e6d26328597ae77ac5831e3417e7cf))

In order to support two off-canvas elements instead of one, the class names needed to set up off-canvas have changed.
Expand Down

0 comments on commit 6b3b0db

Please sign in to comment.