Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should only have to press Esc once in order to stop a Quick Copy or a Disk Copy in Disk Copy #429

Closed
c0mmander8 opened this issue Mar 7, 2021 · 11 comments
Labels
bug DeskTop DeskTop bugs or feature requests Flaky Hard to reproduce issue
Milestone

Comments

@c0mmander8
Copy link
Contributor

Currently, you have to press Esc repeatedly in order to stop a Quick Copy or a Disk Copy in Disk Copy. You should only have to press Esc once in order to stop a Quick Copy or a Disk Copy in Disk Copy.

@c0mmander8 c0mmander8 added DeskTop DeskTop bugs or feature requests bug labels Mar 7, 2021
@inexorabletash
Copy link
Collaborator

The copy_blocks routine calls bit KBDSTRB during the copy and checks for the key during that run of blocks, which is probably the cause. The strobe should only be cleared at the start of the copy.

@inexorabletash
Copy link
Collaborator

Note that I can't repro the problem, so I can't verify a fix.

What size of disk are you copying, and when during the copy are you pressing Escape?

Also, please don't include extraneous information. Repeatedly stating "Quick Copy or a Disk Copy" makes your writing more difficult to understand.

@c0mmander8
Copy link
Contributor Author

This issue occurs intermittently when copying 140K disks, 800K disks and 32 MB volumes. This issue occurs a little more frequently than otherwise when copying the same disk or volume onto itself in the same slot and drive. I am pressing Esc at different points during the copy, mostly towards the beginning of the copy, though.

@inexorabletash
Copy link
Collaborator

Still no luck reproducing here. Are you still using the GSPlus emulator? Running at Unlimited speed?

@c0mmander8
Copy link
Contributor Author

I am still using the GSplus emulator. I am running at 2.8 MHz speed.

@inexorabletash inexorabletash added the Flaky Hard to reproduce issue label Mar 28, 2021
@inexorabletash
Copy link
Collaborator

Does this still repro for you in the 1.2-alpha28 build?

@c0mmander8
Copy link
Contributor Author

This issue still reproduces for me in Apple II DeskTop 1.2 Alpha 28.

@inexorabletash
Copy link
Collaborator

I still have not been able to reproduce this (GSplus, 2.8MHz, trying with 140k and 800k images). The closest I've come is that when using Disk Copy (not Quick Copy) to copy 800k images, there is a long pause during Formatting where everything is frozen - the mouse cursor won't move and the keyboard won't interrupt things. You can't interrupt the format with the Escape key, so it might seem like you have to press it multiple times before it responds.

Any further ideas on reproducing?

@c0mmander8
Copy link
Contributor Author

Try 32 MB disk images in both Quick Copy and Disk Copy. I can repeatedly reproduce this bug, but only intermittently.

@c0mmander8
Copy link
Contributor Author

This bug still reproduces for me in Apple II DeskTop 1.2 Alpha 36.

@inexorabletash inexorabletash added this to the 1.2 milestone Oct 2, 2021
@inexorabletash
Copy link
Collaborator

Thanks; I was finally able to repro. Fix was easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DeskTop DeskTop bugs or feature requests Flaky Hard to reproduce issue
Projects
None yet
Development

No branches or pull requests

2 participants