Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize php's close and open tags in a3-lazy-load.php #24

Open
DrLightman opened this issue Oct 9, 2018 · 0 comments
Open

optimize php's close and open tags in a3-lazy-load.php #24

DrLightman opened this issue Oct 9, 2018 · 0 comments

Comments

@DrLightman
Copy link

	QLD Australia
*/
?>
<?php
define('A3_LAZY_LOAD_FILE_PATH', dirname(__FILE__));
define('A3_LAZY_LOAD_DIR_NAME', basename(A3_LAZY_LOAD_FILE_PATH));

Isn't that a bad practice? It echos a newline. I personally don't see the point of that close/open tags, you could put them on the same line like this if you really must:

?><?php

Or you could simply remove them altogether so everybody is happy? :)

Also, for every php files rather than ending it with an ?> it's better to remove it altogether to avoid the risk to print a newline or spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant