Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links that are not Youtube links are treated as such #15

Closed
Hukadan opened this issue Aug 15, 2015 · 3 comments
Closed

Links that are not Youtube links are treated as such #15

Hukadan opened this issue Aug 15, 2015 · 3 comments

Comments

@Hukadan
Copy link

Hukadan commented Aug 15, 2015

Hi,

Using the unified regular expression introduced in this commit , some links that were not Youtube links were treated at such leading to broken video links. I had to revert this commit to make the plugin work properly again. Did I miss something or is this regular expression too broad ?

Thank for this plugin anyway.

@Hukadan Hukadan changed the title Link that are not Youtube links are treated as such Links that are not Youtube links are treated as such Aug 15, 2015
@a5mith
Copy link
Owner

a5mith commented Aug 19, 2015

Can you provide some links that don't work so I can test, regexr seems to believe the regex is fine and I am unable to grab any data from links other than youtube.

I will try and reproduce though.

@Hukadan
Copy link
Author

Hukadan commented Aug 19, 2015

I saw on the Nodebb forum that you managed to reproduce the issue. I can try to find links that did not work if you still need some.

@a5mith
Copy link
Owner

a5mith commented Aug 19, 2015

Fixed in 26a3429. Update the plugin to latest. 👍

@a5mith a5mith closed this as completed Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants