-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work inside promises? #30
Comments
I'm also having a similar problem problem. Regular errors are being caught correctly, but a TypeError in a render caused by a promise isn't caught and the red screen shows on both debug and release builds |
Hmm. That's interesting @Kebabpizza . I ll take a look at that . But @andrew-wagner89 Red screen should never come in the release builds. .as they are entirely switched off during the build process. |
Hi @Kebabpizza @andrew-wagner89 Can you guys help with a screenshot or a larger snippet? .. I am only getting a warning yellow screen after trying to replicate. And yellow screens dont cause a app crash. |
Hi @master-atul, apologies for the late response. After navigating to another screen with react-navigation, this produces a crash (red screen) instead of a yellow warning. And if you navigate within a promise react-native-exception-handler does not catch this. Here is a sample: https://gist.github.com/Kebabpizza/925531ed9bab37ba6abf48f5de9c812a using |
I was hitting this "bug" repeated times after upgrading RN > 0.50 Today I found out that this is due to the new error boundary handling in React 16. You can use You can read more about it here: |
im experiencing this too, which made me think it isnt working at all |
It behaves bit peculiar for me. I tried the example given in the documentation of this plugin (like this.test() ). I am not sure why this behavior ?? |
That's great! So we don't need this plugin any more right ? |
What we have to do in functional component (there is not componentDidCatch)? |
It does not seem to catch any errors inside promises for me.
I'm navigating to a different view using react-navigation inside a promise, and no errors are caught after this (or inside the promise itself).
fetchUser().then(() => { this.causeAnError() })
The text was updated successfully, but these errors were encountered: