Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS / Android Mismatch in onTap #14

Open
erandagan opened this issue May 1, 2019 · 3 comments
Open

iOS / Android Mismatch in onTap #14

erandagan opened this issue May 1, 2019 · 3 comments

Comments

@erandagan
Copy link

erandagan commented May 1, 2019

On android, the onTap event contains the following parameters:
{x: number, y: number, scale:number}

However, on iOS, the parameters are { point: { x:number, y:number}, target: number } (where target is the react tag of the tapped view).

Moreover, on iOS, x and y are normalized according to the scale already (see this line)

It would be great if the two platforms could provide the same behaviour here. I'd be happy to submit a PR to make the required changes, though it's worth noting that this is a breaking change.

@erandagan
Copy link
Author

@aMarCruz Could you please take a look? I'd be happy to open a PR once we agree on a solution

@aMarCruz
Copy link
Owner

aMarCruz commented May 7, 2019

@erandagan , that was unfortunate in the original design and I see that also in other iOS methods there is that discrepancy.

I would like to normalize the parameters, however I think that doing so would be a breaking change for iOS users. Please open a PR to integrate it into a new major version.

@erandagan
Copy link
Author

Sounds good. Hopefully I'll get to opening a PR this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants