Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktor 2.0 support #175

Closed
joreilly opened this issue Dec 22, 2021 · 10 comments · Fixed by #186
Closed

Ktor 2.0 support #175

joreilly opened this issue Dec 22, 2021 · 10 comments · Fixed by #186

Comments

@joreilly
Copy link

I realise Ktor 2.0 is still in eap right now but just curious if there's know changes needed/planned to support it? I tried to update a project I have here to use Ktor 2.0 (using v0.17.14 of the library) but getting following

Type mismatch.
Required:
RouteScopedPlugin<TypeVariable(B), TypeVariable(F)>
Found:
GraphQL.Feature
@joreilly
Copy link
Author

joreilly commented Jan 1, 2022

Just fyi that Ktor 2.0 is beta now so likely will see more projects starting to use it.

@sangeetds
Copy link

Need to change types, would like to undertake this change.

@NathanPB
Copy link

it makes me pretty worried because @jeggy seems not to be around to address this change

image

@sangeetds
Copy link

@NathanPB check again, @jeggy is still active I guess.

@sangeetds
Copy link

Created #179. It should add support for Ktor 2.0

@NathanPB
Copy link

@NathanPB check again, @jeggy is still active I guess.

Yes, I was getting worried because he used to be very active here and suddenly disappeared

@ronjunevaldoz
Copy link

is this still active?

@berserkore
Copy link

Hey People,

If you are looking to support this library with Ktor 2.0, I made a comment and temporary fix to support Ktor 2.0 until this library get revived.

#185

Cheers

@sangeetds
Copy link

Hey @berserkore @ronjunevaldoz @NathanPB @joreilly and everyone else.
I had already raised a PR #179 for fixing this but I guess the owner is currently inactive now.
I have forked this library where the particular commit is there and I have tested it for very basic cases and was seem to be working. Didn't get much time before to properly maintain it but I think from now I can maintain it since I have a use for it in my personal project too. Would love to get feedback and will plan to actively maintain it soon.

@jeggy
Copy link
Member

jeggy commented May 31, 2022

Hi all. Sorry for being inactive for such a long time.

I will start being active in this community again and I have now opened GitHub discussions and opened a discussion about getting more maintainers on this project (#187).

We want to keep this repository active and maintain the maven repository and the https://KGraphQL.io/ website.

This was linked to pull requests May 31, 2022
@jeggy jeggy closed this as completed in #186 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants