Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pass options to the http module #138

Closed
pogotc opened this issue Feb 20, 2017 · 1 comment
Closed

Cannot pass options to the http module #138

pogotc opened this issue Feb 20, 2017 · 1 comment

Comments

@pogotc
Copy link

pogotc commented Feb 20, 2017

While using this module I ran into this issue: nodejs/node#7931 which can be fixed by passing family: 4 to the request object.

As far as I can tell there's no way to directly pass parameters to the underlying request object, or is there? I think this would be a useful feature to have.

@pogotc
Copy link
Author

pogotc commented Feb 20, 2017

I've created a pull request for this: #139, args now accepts a new parameter request_option that accepts any options that should be passed down to the request function.

@aacerox aacerox closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants