Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing flow types causes circular dependency error #31

Open
bluepnume opened this issue Feb 9, 2018 · 0 comments
Open

Importing flow types causes circular dependency error #31

bluepnume opened this issue Feb 9, 2018 · 0 comments

Comments

@bluepnume
Copy link

bluepnume commented Feb 9, 2018

First off -- amazing plugin, this has saved me from a bunch of problems. Thank you so much!

The issue I'm seeing is this:

// foo.js

import { Bar } from './bar';
// bar.js

import { type Foo } from './foo';

This will cause circular-dependency-plugin to fail. But this makes it very difficult to do things like dependency injection, when the dependency isn't declared statically, but it's passed in.

I get that some people may wish to guard against this, still -- but would it be possible to add a flag to ignore circular dependencies when it's only types which are being circularly imported?

Thanks again for your time on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant