Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PostTypeBuilder label handling with defaults #6

Closed
aaemnnosttv opened this issue Jun 25, 2016 · 0 comments · Fixed by #17
Closed

Improve PostTypeBuilder label handling with defaults #6

aaemnnosttv opened this issue Jun 25, 2016 · 0 comments · Fixed by #17

Comments

@aaemnnosttv
Copy link
Owner

As it is, the methods for setting the singular and plural post type labels only set two keys in the array of labels. Ideally, these methods (or others if it makes more sense) should allow for setting all of the other labels which use them while remaining mutable.

The biggest consideration here is probably making sure that i18n is not sacrificed in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant