I added a pageBackground to be able to use a widget and not just a color (pageColor) as a background #63
Conversation
+ added agreeToLicense bloc support + added afterFirstStartup bloc support + added null support for background_widget.dart + added stream_button.dart as seperate file + added debug support for clear + added stream_check_box_list_tile.dart for intro screen license + separated button.dart from stream_button.dart + simplified flare_animation_widget.dart + added stream_check_box_list_tile.dart + added IntroViews as sub package to modify background + added seed log for stream_value.dart
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 92.32% 88.83% -3.49%
==========================================
Files 15 15
Lines 430 430
==========================================
- Hits 397 382 -15
- Misses 33 48 +15
Continue to review full report at Codecov.
|
+ Added Send Indicator in serial_bluetooth_bloc.dart + changed timeout between commands in serial_bluetooth_bloc.dart + modified intro_screens.dart to fit Android on G5
Moved Buttons up to avoid collision with Page Indicator
|
Please fix the merge conflicts! |
|
@ride4sun can you please rebase on the latest master? Then we can finally get this reviewed and merged 👍 |
|
Sorry I did a former and don't want to spend more time on this. It should
take you 5 minutes to do the change on your main branch.
…On Wed, Apr 7, 2021, 06:24 Matěj Žídek ***@***.***> wrote:
@ride4sun <https://github.com/ride4sun> can you please rebase on the
latest master? Then we can finally get this reviewed and merged 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3BZ24J6JQJYQLAO4FEOOTTHRMJXANCNFSM4J3RQ5HQ>
.
|
Ok, closing. I saw a recent commit so I thought it was related to this PR. I'll probably re-add this feature based on this PR someday. |
|
So is this feature implemented or not. Or are u closing it to get a better
statistics. Would be nice to have a definitive answer here for others as
well.
…On Wed, Apr 7, 2021, 08:30 Matěj Žídek ***@***.***> wrote:
Closed #63 <#63>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3BZ22ACFJXPUE6KEXNQU3THR3CNANCNFSM4J3RQ5HQ>
.
|
|
As you can see the issue related to this PR is not closed meaning it's on the plan to be implemented. It missed After that, the feature can be implemented in a new PR and related changes will be cherry-picked from this PR. Sounds good? |
|
@all-contributors add @ride4sun for code enhancement. |
|
I've put up a pull request to add @ride4sun! 🎉 |
I added a pageBackground to be able to use a widget and not just a color (pageColor) as a background.
I updated the readme but I not sure about the version update.
This addresses #62