Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom solve_triangluar optional #53

Open
1 task
fariedabuzaid opened this issue May 23, 2024 · 0 comments
Open
1 task

Make custom solve_triangluar optional #53

fariedabuzaid opened this issue May 23, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fariedabuzaid
Copy link
Collaborator

fariedabuzaid commented May 23, 2024

The custom implementation of the solve_triangular function is only necessary if onnx export is needed but is a performance bottleneck. We should make it optional to use the implementation in torch.linalg.

  • Extend solve_triangular with another argument, e.g. backend.
    • Depending on the value of the new argument, the function should either use the building implementation or call the torch implementation.
    • Set the default backend to torch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants