Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between README in develop and released version #246

Closed
mojtaba732 opened this issue Jan 14, 2023 · 4 comments
Closed

Mismatch between README in develop and released version #246

mojtaba732 opened this issue Jan 14, 2023 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@mojtaba732
Copy link

When we run the example of readme page, an error occurs in

values = compute_shapley_values(
u=utility, n_iterations=100, mode="truncated_montecarlo"
)

the error is
TypeError: truncated_montecarlo_shapley() got an unexpected keyword argument 'n_iterations'

@mdbenito
Copy link
Collaborator

Hi, in v0.3.0 it is max_iterations. For 0.4.0 we renamed the parameter but haven't released yet. The readme you are reading is in the develop branch, so you see the new documentation.

@mdbenito mdbenito changed the title compute_shapley_values function argument Mismatch between README in develop and released version Jan 14, 2023
@mdbenito mdbenito added bug Something isn't working documentation Improvements or additions to documentation labels Jan 14, 2023
@mdbenito
Copy link
Collaborator

Also see #179

@mdbenito
Copy link
Collaborator

@mojtaba732 I just released 0.4.0. Upgrade with pip and you should be good to go. Release notes here

@mojtaba732
Copy link
Author

@mdbenito Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants