Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsume shapley values into semi-value computation #325

Open
Tracked by #467
mdbenito opened this issue Mar 13, 2023 · 0 comments
Open
Tracked by #467

Subsume shapley values into semi-value computation #325

mdbenito opened this issue Mar 13, 2023 · 0 comments
Assignees
Labels
cleanup when code is ugly or unreadable and needs restyling
Milestone

Comments

@mdbenito
Copy link
Collaborator

mdbenito commented Mar 13, 2023

#319 duplicates some of the methods in value.shapley. We will want to merge as much as possible of the latter into the semi-values, possibly just by calling semivalues() from within the methods in value.shapley.

As of 0.7.0, there are two pieces missing for this:

  • TruncationPolicies for compute_semivalues. This is addressed in Interruptible samplers #321
  • The fact that the general computation of marginal utilities which does not reuse the last computed value doubles the compute wrt. the original implementation. This should be solved by enabling caching, but this can be inconvenient since it relies on memcached. This would be little better if we had a default custom shared memory cache for local caching when using joblib, but ray users still would need to install memcached, unless we use a ray actor as cache, or any mechanism that ray makes available.
@mdbenito mdbenito added the cleanup when code is ugly or unreadable and needs restyling label Mar 13, 2023
@mdbenito mdbenito added this to the v0.6.0 milestone Mar 13, 2023
@mdbenito mdbenito mentioned this issue Mar 13, 2023
4 tasks
@mdbenito mdbenito modified the milestones: v0.7.0, v0.9.0 Apr 20, 2023
@mdbenito mdbenito self-assigned this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Development

No branches or pull requests

1 participant