Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule-Based Models' fit interface #59

Closed
opcode81 opened this issue Aug 3, 2021 · 0 comments
Closed

Rule-Based Models' fit interface #59

opcode81 opened this issue Aug 3, 2021 · 0 comments

Comments

@opcode81
Copy link
Collaborator

opcode81 commented Aug 3, 2021

The overrides of the rule-based models violate the substitution principle. The specific fit methods should be deleted.
It is also unexpected for the fitPreprocessors argument to be completely ignored for rule-based models in VectorMode.fit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@opcode81