Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_and_render action succeed #2

Closed
fariedabuzaid opened this issue Feb 4, 2022 · 3 comments · Fixed by #13 or #37
Closed

Make test_and_render action succeed #2

fariedabuzaid opened this issue Feb 4, 2022 · 3 comments · Fixed by #13 or #37
Assignees
@fariedabuzaid
Labels
bug Something isn't working

Comments

@fariedabuzaid
Copy link
Collaborator

All notebooks in the solutions branch need to be completely runnable without errors
@fariedabuzaid fariedabuzaid added the bug Something isn't working label Feb 4, 2022
@mdbenito
Copy link

mdbenito commented Mar 11, 2022 •
edited
Loading

Despite the actions succeeding now. This is NOT fixed. See my comment 4a81ff0#r68477594.

@Xuzzo Xuzzo mentioned this issue Mar 16, 2022
Merged
@Xuzzo Xuzzo linked a pull request Mar 18, 2022 that will close this issue
Fix notebooks tests #13
Merged
@mdbenito
Copy link

mdbenito commented Apr 4, 2022

docs build still fails (it's commented out)

@mdbenito mdbenito reopened this Apr 4, 2022
@fariedabuzaid fariedabuzaid removed their assignment Dec 12, 2022
@fariedabuzaid
Copy link
Collaborator Author

test_and_render now runs on master.
Pipeline succeeds but excludes 2 notebooks. See comments on omitted notebooks in
notebooks/test_notebooks.py

@fariedabuzaid fariedabuzaid self-assigned this Mar 27, 2023
@fariedabuzaid fariedabuzaid mentioned this issue Apr 23, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fariedabuzaid fariedabuzaid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@mdbenito @fariedabuzaid