Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to support a higher version of trino for the ranger version #7

Closed
A-little-bit-of-data opened this issue Jun 8, 2023 · 15 comments · Fixed by #12
Closed

How to support a higher version of trino for the ranger version #7

A-little-bit-of-data opened this issue Jun 8, 2023 · 15 comments · Fixed by #12
Labels
question Further information is requested

Comments

@A-little-bit-of-data
Copy link

Hello, I would like to ask you a question, what did you do when you adapted the ranger version and the trino version, recently I need to use a higher version of trino, I have made some attempts, but unfortunately, all failed, Can you share your experience? Thank you so much!

@aakashnand
Copy link
Owner

Upgrading the trino-ranger-plugin with the latest trino version sometime requires making changes to the code base of the ranger-plugin. So its not that straightforward

@aakashnand aakashnand added the question Further information is requested label Jun 8, 2023
@A-little-bit-of-data
Copy link
Author

Upgrading the trino-ranger-plugin with the latest trino version sometime requires making changes to the code base of the ranger-plugin. So its not that straightforward

Thank you very much for your reply. I will try again when I have time. I would like to ask you, is there any plan to upgrade the trino version to adapt to ranger recently or in the future?

@dawsongzhao0523
Copy link

Yes I also would like need trino 415 version

@Yiutto
Copy link

Yiutto commented Jul 27, 2023

can you update trino 420 verision

@pilipyukaaa
Copy link

hello there, which one version is last supported by ranger?

@Peihao-Zhu
Copy link

Hi @aakashnand , would you be able to open source the ranger-trino-plugin, so that we may contribute to it to support more features introduced by higher version of Trino. And did you start you code from ranger's code base, since they didn't update that part of code for over two years, so may think a bit stale.

@2416210017
Copy link

Can you update the latest version of trino support?😆

@aakashnand
Copy link
Owner

Hi @aakashnand , would you be able to open source the ranger-trino-plugin, so that we may contribute to it to support more features introduced by higher version of Trino. And did you start you code from ranger's code base, since they didn't update that part of code for over two years, so may think a bit stale.

@Peihao-Zhu Its already open sourced here https://github.com/aakashnand/ranger/tree/master/plugin-trino

But as you said the source code of ranger didn't get update frequently for trino its difficult to keep up the development.

Trino source code moves very fast where Ranger moves very slow, this has been headache of trino users for long time.

I cannot guarantee the fork update but I will definitely think about how to fix this soon.

@okayhooni
Copy link

@aakashnand

Currently, I do start to update your ranger plugin codes to be compatible with the SPI of latest Trino (version 433).

If I am done, I will submit a pull request on this repository this weekend! :)

@okayhooni
Copy link

I updated this plugin and tested it with Trino v433(latest) and Ranger v2.4.0..! :)

apache/ranger#290

@aakashnand
Copy link
Owner

@okayhooni Thank you so much. For this awesome work. I think the PR you created on Ranger repo will not get response soon but I will use your patch to update this repository to help other members. Great Job. I am going to update fork on my repo. Would you be interested in sending PR to that again?

@okayhooni
Copy link

@aakashnand I made a pull request to your forked repository like below :) Thank you!

@recholio
Copy link

recholio commented Dec 1, 2023

@okayhooni Since you've tested it, could you share your build environment details + mvn command? I'm trying to build it from your fork, but keep getting an errors like these:

 error: cannot access CatalogSchemaName {code}

@nghiabuilvb
Copy link

@okayhooni Since you've tested it, could you share your build environment details + mvn command? I'm trying to build it from your fork, but keep getting an errors like these:

 error: cannot access CatalogSchemaName {code}

This error is about java version. You try to change java 17.

@aakashnand
Copy link
Owner

Its been so delayed but I have started to work on updating this repo with latest version.

@aakashnand aakashnand linked a pull request Feb 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants