Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test/impl AVL trees #83

Closed
PatrykOlejniczak opened this issue Oct 19, 2018 · 4 comments
Closed

Fix test/impl AVL trees #83

PatrykOlejniczak opened this issue Oct 19, 2018 · 4 comments
Assignees
Labels
bug Report an issue with the project

Comments

@PatrykOlejniczak
Copy link
Collaborator

PatrykOlejniczak commented Oct 19, 2018

Hello,
same story just like with RedBlackTree issue, I noticed that not all tests pass.
I would like to work on these tests or implementation depends on what the problem will turn out to be.
I will try to add more test cases.

Related with an earlier reported problem #76

Regards.

@gregfra
Copy link
Contributor

gregfra commented Dec 29, 2018

Patryk, I just made a PR to correct the failing subtest. You can review and/or add AVL tree subtests and I can look those over for you.

@PatrykOlejniczak
Copy link
Collaborator Author

Hi, for me looks good, thx for do that, but I think repo is dead or susspended (my pr for RBT is hanging a month), maybe owner say something @aalhour

@aalhour
Copy link
Owner

aalhour commented Jul 15, 2019

Hello @PatrykOlejniczak, @gregfra,

I'd be more than happy to review and accept contributions but after I get the unit tests fixed. If you guys can help me with that I'd appreciate it a lot! The problem is that Travis CI no longer runs the unit tests projects and I would like someone to help me fix that.

Cheers,
Ahmad

@PatrykOlejniczak
Copy link
Collaborator Author

I'll close this issue fix #76 is already merged.

Thanks @gregfra

@aalhour aalhour added the bug Report an issue with the project label Nov 1, 2019
@aalhour aalhour added this to To do in Kanban Board via automation Nov 1, 2019
@aalhour aalhour moved this from To do to Done in Kanban Board Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report an issue with the project
Projects
Kanban Board
  
Done
Development

No branches or pull requests

3 participants