Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple issues with catalan numbers #74

Closed
nickntg opened this issue Jul 6, 2018 · 1 comment
Closed

Multiple issues with catalan numbers #74

nickntg opened this issue Jul 6, 2018 · 1 comment
Assignees
@nickntg
Labels
bug Report an issue with the project
Projects
Kanban Board

Comments

@nickntg
Copy link
Contributor

nickntg commented Jul 6, 2018

Specifically:

  • The algorithm does not produce correct numbers when large ranks are used.
  • The implementation of GetNumberByBinomialCoefficients() produces different results when rank >= 32.
  • As a result of the above, CatalanNumbersTest.DoTest() fails.
  • There are no tests to validate the algorithm implementation against known and documented catalan numbers.
@nickntg nickntg mentioned this issue Jul 6, 2018
Merged
@aalhour aalhour added this to To do in Kanban Board Oct 30, 2019
@aalhour aalhour added the bug Report an issue with the project label Oct 30, 2019
@aalhour
Copy link
Owner

aalhour commented Oct 31, 2019

Closing this as #75 is now merged.

@aalhour aalhour closed this as completed Oct 31, 2019
Kanban Board automation moved this from To do to Done Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickntg nickntg

Labels
bug Report an issue with the project
Projects
Kanban Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aalhour @nickntg