Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please make host part of OpenAIConfig #100

Closed
ChrisGClark opened this issue Mar 2, 2023 · 3 comments · Fixed by #102
Closed

please make host part of OpenAIConfig #100

ChrisGClark opened this issue Mar 2, 2023 · 3 comments · Fixed by #102
Labels
enhancement New feature or request

Comments

@ChrisGClark
Copy link

Hi,

Open AI is starting to deploy environments to Azure. Would be great to have host part of OpenAIConfig, so createHttpClient can take from config, rather than hardcoded. I couldn't see an easy way to override as many classes are marked as internal.

Thankyou.
@aallam aallam added the enhancement New feature or request label Mar 2, 2023
@aallam aallam mentioned this issue Mar 2, 2023
Merged
@aallam
Copy link
Owner

aallam commented Mar 2, 2023

Hello @ChrisGClark - I've added your suggestion to the latest release (v3.0.0) of the library! please give it a try :)

@ChrisGClark
Copy link
Author

Amazing super fast! Thanks a lot and also for the lib.

@ChrisGClark
Copy link
Author

i'll use latest release today :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): add custom host config aallam/openai-kotlin
2 participants
@aallam @ChrisGClark