Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When default path is file, the directoryOnly = false is not work #7

Open
ayizhi opened this issue Oct 13, 2019 · 0 comments
Open

When default path is file, the directoryOnly = false is not work #7

ayizhi opened this issue Oct 13, 2019 · 0 comments

Comments

@ayizhi
Copy link

ayizhi commented Oct 13, 2019

In PathAutocomplete.js line 21

if (!this.cwd.isExistingDirectory()) { throw new Error(The provided working directory ${cwd} does not exist or is not a directory.); }

then, the directoryOnly is meaningless; It should be:

if (!this.cwd.isExistingDirectory() && directoryOnly) { throw new Error(The provided working directory ${cwd} does not exist or is not a directory.); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant