Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lab 1 Part 1.1] A typo in the matrix indexes? #111

Open
datasith opened this issue May 16, 2022 · 1 comment
Open

[Lab 1 Part 1.1] A typo in the matrix indexes? #111

datasith opened this issue May 16, 2022 · 1 comment

Comments

@datasith
Copy link

The last matrix defined by the user in section 1.1 has to be a 2-d Tensor. Thus, it'll have a shape of (n, 2) or (2, n). The code in the Lab 1 notebook has:

row_vector = matrix[1]
column_vector = matrix[:,2]
scalar = matrix[1, 2]

This assumes the column-rank to be >=3. IMHO, it should instead be:

row_vector = matrix[1]
column_vector = matrix[:,1]
scalar = matrix[0, 1]

And assume the user will choose a (2,2) matrix as their solution.

@datasith
Copy link
Author

See PR #59 for more details on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant