Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max fire area very large #235

Closed
kowalskiw opened this issue Jan 12, 2024 · 2 comments · Fixed by #236
Closed

Max fire area very large #235

kowalskiw opened this issue Jan 12, 2024 · 2 comments · Fixed by #236
Assignees
@kowalskiw
Labels
bug fire_submodel Issues with CFAST, fire.* and fire-related

Comments

@kowalskiw
Copy link
Member

There are iterations identified where max_area is suspiciously large. To be investigated for possible bug.
@kowalskiw kowalskiw added bug fire_submodel Issues with CFAST, fire.* and fire-related labels Jan 12, 2024
@kowalskiw kowalskiw self-assigned this Jan 12, 2024
@kowalskiw
Copy link
Member Author

The bug was identified as a bug in orig_area in montecarlo.cfast_mcarlo.DrawAndLog._draw_fire_maxarea calculation. At the moment it is calculated as the fire was placed in the middle of the compartment, which is not true anymore.

To be fixed with high priority.

@kowalskiw kowalskiw linked a pull request Jan 13, 2024 that will close this issue
Maximum fire area fixed #236
Merged
@kowalskiw
Copy link
Member Author

Resolved since 5689503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kowalskiw kowalskiw

Labels
bug fire_submodel Issues with CFAST, fire.* and fire-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maximum fire area fixed aamks/aamks
1 participant
@kowalskiw