Support submodules

[ekohl]

Currently when you use git up in a submodule you get the following stack trace:

/usr/lib/ruby/gems/1.8/gems/grit-2.4.1/lib/grit/git-ruby.rb:114:in `chdir': Not a directory - /some/path/to/our/submodule/.git (Errno::ENOTDIR)
    from /usr/lib/ruby/gems/1.8/gems/grit-2.4.1/lib/grit/git-ruby.rb:114:in `refs'
    from /usr/lib/ruby/gems/1.8/gems/grit-2.4.1/lib/grit/ref.rb:13:in `find_all'
    from /usr/lib/ruby/gems/1.8/gems/grit-2.4.1/lib/grit/repo.rb:212:in `branches'
    from /usr/lib/ruby/gems/1.8/gems/git-up-0.5.8/lib/git-up.rb:88:in `remote_map'
    from /usr/lib/ruby/gems/1.8/gems/git-up-0.5.8/lib/git-up.rb:84:in `remotes'
    from /usr/lib/ruby/gems/1.8/gems/git-up-0.5.8/lib/git-up.rb:8:in `run'
    from /usr/lib64/ruby/gems/1.8/gems/git-up-0.5.8/bin/git-up:5
    from /usr/bin/git-up:8:in `load'
    from /usr/bin/git-up:8

That's because it's a file with a pointer to the real directory:

gitdir: /the/real/path/to/our/submodule

I think it would be a nice feature to support.

[aanand]

Yeah, this has been raised before. I agree it'd be nice, but it's not something I'm personally interested in working on. Pull requests welcome!

[ekohl]

I'll look into this. Not that experienced in ruby, but this might be a good time to learn. Btw, if you use #24 it will create a reference in both issues.

[ekohl]

Looks like you can fix it in a 1-liner which I'll try to upstream in grit. No changes needed in git-up.

diff --git a/lib/grit/git-ruby.rb b/lib/grit/git-ruby.rb
index 290ebcd..ddf5f69 100644
--- a/lib/grit/git-ruby.rb
+++ b/lib/grit/git-ruby.rb
@@ -116,6 +116,10 @@ module Grit
     def refs(options, prefix)
       refs = []
       already = {}
+
+      # submodule
+      @git_dir = File.read(@git_dir)[/gitdir: (.*)/, 1] if File.file?(@git_dir)
+
       Dir.chdir(@git_dir) do
         files = Dir.glob(prefix + '/**/*')
         files.each do |ref|