Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about excluding/linking coverage files with Melange+Dune #402

Open
mlms13 opened this issue Jun 15, 2022 · 4 comments
Open

Confused about excluding/linking coverage files with Melange+Dune #402

mlms13 opened this issue Jun 15, 2022 · 4 comments
Milestone

Comments

@mlms13
Copy link

mlms13 commented Jun 15, 2022

I recently updated Relude to build with Melange (which uses Dune). You can see the latest coverage report on Coveralls. Specifically, you can see that the file tree looks like this:

image

I have two questions about this, which may or may not be related:

  1. Is it possible to hide the node_modules and __tests__ within the _build directory from the coverage report? In my bsconfig.json, I already have this, but it doesn't seem to be ignoring the _test.re files:
    "ppx-flags": [
      [
        "bisect_ppx/ppx",
        "--exclude-files",
        ".*_test.re$$"
      ]
    ]
  2. Is it possible to get the Coveralls report to link to the files? It's picking up on the source files that got copied to _build (which isn't checked in) instead of the ones in src, so the Coveralls file view just says "Source not available."
@aantron aantron modified the milestones: 2.8.2, 2.8.3 Apr 8, 2023
@aantron
Copy link
Owner

aantron commented Jun 25, 2023

Sorry for the huge delay. Please let me know if you are still using Bisect, Melange, and Dune, and whether this is still an issue with Dune's new Melange integration that was released in Dune 3.8.0.

@mlms13
Copy link
Author

mlms13 commented Jun 27, 2023

No worries, and I'm glad to see you back! I have no idea if this is still relevant, but I started moving bs-decode to the latest melange and dune, where bsconfig.json is no longer a thing. I know that project was also using bisect_ppx, so I'll have to see if any of the same issues with files in node_modules and _build happen there. I'll let you know!

@aantron
Copy link
Owner

aantron commented Jun 29, 2023

Thank you!

@jchavarri
Copy link

ftr I pushed some branch to make bisect runtime build on melange. I left the PR as draft so that others interested can find it, but I don't think it should be considered for merge because it would require lifting a lot of core deps lower bounds to the most recent version (OCaml compiler, dune, ...): #428.

Maybe in the future there will be an option to opt-in for melange, once Dune handles package management (see ocaml/dune#7939 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants