Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melange compatible version #431

Open
jakubrpawlowski opened this issue Nov 12, 2023 · 3 comments
Open

Melange compatible version #431

jakubrpawlowski opened this issue Nov 12, 2023 · 3 comments

Comments

@jakubrpawlowski
Copy link

@jchavarri pointed me at this working branch of @joprice
master...joprice:bisect_ppx:add-melange-support+flake

@trite, @mlms13 and I are hoping to get melange compatible version of bisect_ppx out to opam. Is there anything else that needs to be finished here?

We're all down to help you with it.

CC @aantron

@trite
Copy link

trite commented Nov 13, 2023

Getting this into opam would be a huge help towards getting relude and a fork of bastet into opam as well. Happy to help where I can!

@jchavarri
Copy link

Thanks for your help taking this to the finish line.

One thing that the branch / PR should fix that is not at the moment is restoring compatibility with ReScript. In the branch, we just replaced attributes like @bs with u, or @@module with @@mel.module.

To maintain compatibility with ReScript, the original attributes should remain in place. Maybe some alert silencing has to be used for Melange ppx, an example can be seen here.

Another thing that should be looked into is how to add melange to the deps in opam while keeping the current bisect_ppx constraint on "ocaml" {>= "4.03.0"}. This is impossible at the moment, as Melange is only compatible with OCaml 5.1, so maybe there can be an alternate package melange-bisect_ppx which adds the support for Melange. That would allow existing bisect_ppx in OCaml to remain unaffected by the Melange addition.

@aantron
Copy link
Owner

aantron commented Nov 13, 2023

I will take a look at this in some amount of days (currently sorting out issues in Dream maintenance). Definitely need to add Melange support and we will figure out how to deal with the dependencies, constraints, and all the compatibility issues. And thanks to everyone, very helpful contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants