Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on OCaml 4.13.1 #66

Closed
rwmjones opened this issue Oct 5, 2021 · 2 comments
Closed

Fails to build on OCaml 4.13.1 #66

rwmjones opened this issue Oct 5, 2021 · 2 comments

Comments

@rwmjones
Copy link

rwmjones commented Oct 5, 2021

File "test/test_kstream.ml", line 175, characters 4-34:
175 |     tap (Buffer.add_char buffer) s |> ignore;
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error (warning 5 [ignored-partial-application]): this function application is partial,
maybe some arguments are missing.
@rwmjones
Copy link
Author

rwmjones commented Oct 5, 2021

A simple fix was just to ignore the error by changing test/dune to:

- (flags (:standard -w +A-44-48)))
+ (flags (:standard -w +A-5-44-48)))

@aantron aantron closed this as completed in fc7f1d1 Nov 7, 2021
@aantron
Copy link
Owner

aantron commented Nov 7, 2021

Thanks! I made the warning flags less aggressive in fc7f1d1. They were a holdover from ocamlbuild days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants