Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argparse to remove manual code edits #1

Closed
Hir0ki opened this issue Sep 25, 2020 · 4 comments
Closed

add argparse to remove manual code edits #1

Hir0ki opened this issue Sep 25, 2020 · 4 comments
Projects

Comments

@Hir0ki
Copy link

Hir0ki commented Sep 25, 2020

you can use the standard library module argparser to get the username, password and the path to the browser webdriver and the browser type.

This would be great so a don't have to has to change the coding.

@aapatre
Copy link
Owner

aapatre commented Sep 26, 2020

Thanks a lot for the info! I will check!

@aapatre
Copy link
Owner

aapatre commented Sep 27, 2020

Done! Created a requirements.py file to automatically install requirements.
Webdrivers are now taken care of by the webdriver-manager module.

@Hir0ki
Copy link
Author

Hir0ki commented Sep 28, 2020

Greate that you automated it, but i would have used setup.py for that. Here is a link to a course that explains how to structure python applications. They explain how to use setup.py so you don't have to write a custom script.

You also added the settings.txt file where you can put your login data, which is a great idea. Maybe you can use a config file format for that and the configparser module to parse it. You can find guids how to use it: here and here

@aapatre
Copy link
Owner

aapatre commented Sep 28, 2020

Will check and make the necessary changes. Once again, thanks for the info.

aapatre pushed a commit that referenced this issue Oct 4, 2020
Refresh fork to be even with master
@Hir0ki Hir0ki closed this as completed Oct 5, 2020
@fakeid30 fakeid30 added this to Need further discussion in Roadmap Oct 9, 2020
fakeid30 added a commit that referenced this issue Nov 9, 2020
@fakeid30 fakeid30 moved this from Needs further discussion to Done in Roadmap Nov 29, 2020
fakeid30 added a commit that referenced this issue Dec 2, 2020
Added schedule run to the CI workflow
restyled-io bot pushed a commit that referenced this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Done
Development

No branches or pull requests

2 participants