Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gadget toolbox UI is terrible #24

Closed
5 of 6 tasks
JoeLudwig opened this issue Oct 26, 2019 · 8 comments
Closed
5 of 6 tasks

Gadget toolbox UI is terrible #24

JoeLudwig opened this issue Oct 26, 2019 · 8 comments
Assignees

Comments

@JoeLudwig
Copy link
Collaborator

JoeLudwig commented Oct 26, 2019

  • Gadgets collide with each other
  • The "I'm in range" indicator of increasing the scale is hard to see on many gadgets
  • Gadget "icons" are all different sizes
  • Gadget names don't appear anywhere
  • There's no way to remove a gadget from the list once it appears there
  • The scroll thumb (if that's even the right metaphor) is too small
@JoeLudwig JoeLudwig added this to To do in Publishing the repo via automation Oct 26, 2019
@JaredMonkey JaredMonkey self-assigned this Oct 26, 2019
@JaredMonkey
Copy link
Contributor

Making something like this. Back facing spheres, with 3d assets inside.
gadgetui

@JoeLudwig
Copy link
Collaborator Author

That looks nice. Have you tried prototyping that in Aardvark?

@JaredMonkey
Copy link
Contributor

Thanks! I'll get the back facing asset in, and start with a static radial layout to see how it is in app.

@JaredMonkey
Copy link
Contributor

sphere-wrappers

Backfacing spheres work as expected and seem to be decent in Aardvark with the lighting update. I also have a means to make new environment maps in the right format now. I could even bring in the one from the comp. I've got a clear path to getting Gadget Seeds to look like the comp I can get going quickly.

I tried laying out the gadget seeds with CSS and the underlying html div classes got styled, but the aardvark components didn't seem to get adjusted. I was prototyping in Chrome dev tools to start out with.

Going to go down a path of wrapping the Gadget Seeds in AvTransforms and lay things out better tomorrow.

@JoeLudwig
Copy link
Collaborator Author

I added "scaleToFit" to models, which should help with gadget scale. See AvGadgetSeed for examples

I also fixed a bug with sphere-sphere intersections not taking scale into account, which was causing the radius of the gadget seeds in the control panel to be very different from the size of the models. (The control panel is scaled by 0.25, but the radius being used for those controls was unscaled.)

Those should make things work better.

@JaredMonkey JaredMonkey moved this from To do to In progress in Publishing the repo Dec 3, 2019
@JoeLudwig JoeLudwig removed this from In progress in Publishing the repo Dec 8, 2019
@JoeLudwig JoeLudwig added this to To do in Beta via automation Dec 8, 2019
@JoeLudwig JoeLudwig added this to To do in Alpha Dec 14, 2019
@JaredMonkey
Copy link
Contributor

JaredMonkey commented Dec 16, 2019

scaleToFit works well. Trying out some layout logic

image

@JoeLudwig
Copy link
Collaborator Author

Are you still thinking about this, or should we unassign it?

@JoeLudwig
Copy link
Collaborator Author

Gadget menu has been completely replaced, and most of these issues are better. If there are any issues with the new one (which seems likely), we should open a new Github issue to track it.

Beta automation moved this from To do to Done Aug 9, 2020
Alpha automation moved this from To do to Done Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Alpha
  
Done
Beta
  
Done
Development

No branches or pull requests

2 participants