Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded API server address breaks deployment across multiple servers. #4

Open
larsgeb opened this issue Jul 8, 2020 · 1 comment

Comments

@larsgeb
Copy link

larsgeb commented Jul 8, 2020

const serverHostname = `localhost:${PORT}`;

One line in the websocket.js file still uses a hardcoded server location; localhost. This gave some problems when running the servers on separate machines. I think it is nice to allow one to set this URL from an environment variable. Now, when reading a url from the environment variable, typically it is lead by http://. This needs to be replaced by ws://.

I'll update this in a PR. 😉

@aaron5670
Copy link
Owner

I look forward on your PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants