Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guttenberg Editor? #23

Open
JonTheNiceGuy opened this issue Jul 1, 2020 · 5 comments · May be fixed by #25
Open

Guttenberg Editor? #23

JonTheNiceGuy opened this issue Jul 1, 2020 · 5 comments · May be fixed by #25

Comments

@JonTheNiceGuy
Copy link
Contributor

I don't really know where to start, but having the new Guttenberg editor might be useful for those new to Wordpress?

@aaroncampbell aaroncampbell linked a pull request Sep 24, 2021 that will close this issue
@aaroncampbell
Copy link
Owner

This is now in progress in #25 - feedback and testing would be great.

@aaroncampbell
Copy link
Owner

Note: There's no migrator yet - that's on the list, but for now you'll need to create new slideshows to test.

@JonTheNiceGuy
Copy link
Contributor Author

I'm testing this now. I'll give feedback shortly :)

@JonTheNiceGuy
Copy link
Contributor Author

Apologies for the delay - I broke my testing environment! Sorted now!

So, that new branch looks good, but I don't see how to create new slides, nor can I see any way to add speaker notes. I'm guessing I'm just looking at this really early in the development cycle?

So, for context, I cloned your repo, merged in #19 and then ran vagrant up, and vagrant SSH, then

sudo -i
cd /var/www/html/wp-content/plugins/presenter
git fetch
git merge origin/new-editor-support

I then accessed the vagrant Wordpress environment, and created a new presentation, and had a single slide on-page.

@aaroncampbell
Copy link
Owner

Sorry that it took me so long to get back to this.

Unfortunately with Gutenberg, we'll now need to include build steps before the plugin is released (or in this case tested). Basically you'll need to npm install in the plugin directory, then npm run build-mult (for now, when this is all done we should make sure just npm run build works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants