Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest algorithm optimization: Levenshtein distance #65

Closed
aarondandy opened this issue Mar 4, 2022 · 1 comment
Closed

Suggest algorithm optimization: Levenshtein distance #65

aarondandy opened this issue Mar 4, 2022 · 1 comment
Milestone

Comments

@aarondandy
Copy link
Owner

Because this is a port of the original library, I don't want to get too creative with the algorithms. For suggest, especially, these brute forcing nested loops can really hurt as the x64 compilers don't put the same amount of up-front effort into optimizations. Maybe something like Levenshtein distance, which I don't even know if I spelled correctly, could be of use without changing the results?

If something can be improved there, the benefits could impact #33, #40, and #43 .

Learning resources from https://github.com/Turnerj/Quickenshtein#learning-resources

@aarondandy aarondandy added this to the 4.0 milestone Mar 4, 2022
@aarondandy aarondandy changed the title Suggest algorithm optimization Suggest algorithm optimization: Levenshtein distance Mar 4, 2022
@aarondandy
Copy link
Owner Author

I'm not really sure if this can help with the ngram substring performance but will re-open if I learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant