You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The starting week of the year could vary depending on region,
From moment.js documentation:
- The week of the year varies depending on which day is the first day of the week (Sunday, Monday, etc), and which week is the first week of the year.
- For example, in the United States, Sunday is the first day of the week. The week with January 1st in it is the first week of the year.
- In France, Monday is the first day of the week, and the week with January 4th is the first week of the year.
This would mean,
moment.week() on the last week of December could return a 53 / 52 / 1
moment.week() on the first week of January could return a 53 / 52 / 1
Currently this is not handled in the yearView and the monthView and would result in (refer screenshots)
yearView: last week of December or first week of January getting cropped
monthView: Only last week of December or first week of January is displayed rest of the weeks are cropped
Expected Behaviour
While rendering the chart grids in chart_grid.js for YearView and monthView, add conditions to handle the following scenarios
last week of December could be a 53 / 52 / 1
first week of January could be a 53 / 52 / 1
Actual Behaviour
Currently the chart assumes that the last week of December ends in week 52 and first week of Jan starts in week 1
Basic Information
kibana version: 6.4
Screenshots yearView (Dec 2018): last week of Dec getting cropped
yearView (Jan 2019): first week of Jan getting cropped
monthView (Jan 2019): only first week of Jan displayed
The text was updated successfully, but these errors were encountered:
From moment.js documentation:
moment.week()
on the last week of December could return a 53 / 52 / 1moment.week()
on the first week of January could return a 53 / 52 / 1yearView
and themonthView
and would result in (refer screenshots)yearView:
last week of December or first week of January getting croppedmonthView:
Only last week of December or first week of January is displayed rest of the weeks are croppedExpected Behaviour
chart_grid.js
for YearView and monthView, add conditions to handle the following scenariosActual Behaviour
Basic Information
kibana version: 6.4
Screenshots
yearView (Dec 2018)
: last week of Dec getting croppedyearView (Jan 2019)
: first week of Jan getting croppedmonthView (Jan 2019)
: only first week of Jan displayedThe text was updated successfully, but these errors were encountered: