Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential to skip records due to PartitionOffsetState.incOffsets incrementing offsets for all seen partitions #3

Open
tonyblundell opened this issue Sep 3, 2020 · 1 comment

Comments

@tonyblundell
Copy link

Hi Aaron,

Here's another issue that came up during testing.

Currently, as PartitionOffsetState.incOffsets increments offsets for all known partitions, there's a potential for records to be skipped. AckableRecord probably needs to keep track of the partition it came from and increment only that one.

More than happy to fix and share back, however it won't get onto our roadmap until October at the earliest, so raising here in-case you need to fix more urgently for any other projects.

BTW, thanks for accepting that last pull-request. Would you mind publishing to Maven Central if all's well with it please?

Cheers,
Tony

@aaronp
Copy link
Owner

aaronp commented Sep 14, 2020

Cheers Tony - apologies for the delayed response; and for leaving the 0.7.3 on sonatype unpublished!

That's out now, and I'll try and get some time to get some more solid tests in around repartitioning scenarios. I'd love to catch up and hear about the work you've all been doing.

Thanks again for your PR and comments - hope you're keeping well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants