Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@extend doesn't work in media queries #8

Open
elizabethyalkut opened this issue Sep 4, 2018 · 0 comments
Open

@extend doesn't work in media queries #8

elizabethyalkut opened this issue Sep 4, 2018 · 0 comments

Comments

@elizabethyalkut
Copy link

This is a SASS thing (discussion of possible solution: sass/sass#1050 but it doesn't look likely to get implemented anytime soon if ever) , not a tyfy thing, but since @extend doesn't work within media queries, I'd like to propose that things such as .list-flex etc. should be built out of mixins. This would allow us to do something like:

ul.menu {
    @media (min-width: $mediumish-shy) {
      @include list-flex;
      @include list-flex-center;
    }
    @extend .list-nobullet;
    @extend .reverse;
}

so the layout of a list could change depending on available screen size. Currently, we have to actually duplicate the code in, e.g., .list-flex in responsive contexts.

There's support for this point of view:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant