Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enforce trailing slashes #6

Closed
strugee opened this issue Jun 5, 2018 · 4 comments
Closed

Don't enforce trailing slashes #6

strugee opened this issue Jun 5, 2018 · 4 comments

Comments

@strugee
Copy link
Contributor

strugee commented Jun 5, 2018

I just got this error from indielogin.com:

Your GitHub profile linked to https://strugee.net but we were expecting to see https://strugee.net/. Make sure you link to https://strugee.net/ in your GitHub profile.

Notice the trailing /. This feels too pedantic for no good reason.
@aaronpk
Copy link
Owner

aaronpk commented Jun 5, 2018

I literally just shipped a fix for this. When did you get this error?

@strugee
Copy link
Contributor Author

strugee commented Jun 5, 2018

Maybe 5 minutes before I filed the issue? Let me try to reproduce.

@strugee
Copy link
Contributor Author

strugee commented Jun 5, 2018

I can still reproduce on production indielogin.com.

@aaronpk aaronpk closed this as completed in 2106ad9 Jun 5, 2018
@aaronpk
Copy link
Owner

aaronpk commented Jun 5, 2018

Sorry bout that! I fixed a different issue with github logins but fixed this issue with twitter. Should be fixed in 2106ad9 now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronpk @strugee