Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example seems not to work here with me #3

Open
braendi opened this issue Feb 3, 2020 · 2 comments
Open

Example seems not to work here with me #3

braendi opened this issue Feb 3, 2020 · 2 comments

Comments

@braendi
Copy link

braendi commented Feb 3, 2020

Hi Aaron
I just started to read your book "Oauth2 simplified", but now im struggling already with the first example with GitHub. When I point my browser to localhost:8000 I get the login page as expected. Click on "Log In" redirects me to GitHub-Login. Here's my first issue: in the console, I get a warning "Cross-Origin Read Blocking (CORB) blocked cross-origin response https://api.github.com/_private/browser/stats with MIME type application/json. See https://www.chromestatus.com/feature/5629709824032768 for more details". Though, it seems to work so far. After logging in, I'm being redirected back to localhost:8000/index.php, but still get the "Not logged in" Text. When I log the access token to the console, its empty. Where's the mistake? I work on Windows 10.
Regards,
Stefan

@aaronpk
Copy link
Owner

aaronpk commented Feb 24, 2020

I see the CORB error you're talking about, but that's appearing on GitHub's website, it's not from your code. It looks like GitHub needs to update something to account for that. This application doesn't do any of the logic in JavaScript, so there isn't really a place this app could be causing JavaScript errors.

As for being redirected back and not logged in, make sure your browser isn't blocking cookies, and make sure you start at http://localhost:8000/ and not http://127.0.0.1:8000 since the browser won't share cookies between those two different hostnames.

@parasuram-tanguturu
Copy link

parasuram-tanguturu commented Sep 1, 2020

i am also facing same issue ,
Trying to access array offset on value of type null in \github.php on line 68. for github.php

After logging in, I'm being redirected back to localhost:8000 .. in console i am seeing above message

but from restclient when i tied with similar request it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants