Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSG: fixed output when both tone & noise are disabled #30

Merged
merged 1 commit into from Apr 16, 2022

Conversation

hyano
Copy link
Contributor

@hyano hyano commented Apr 2, 2022

This is a patch to fix incorrect behavior of the mixer-control register in SSG.

ch_noise_enable_n()/ch_tone_enable_n() are not good names, but I couldn't have a better one.

@aaronsgiles
Copy link
Owner

Interesting. Can you point me to some examples I can look at to see this behavior?

@hyano
Copy link
Contributor Author

hyano commented Apr 10, 2022

@aaronsgiles Thanks for your reply.

I'm not sure if it is good example for you,
but you can confirm with "SPACE HARRIER" for NEC PC-8801mkII SR (Japanese retro PC).
Game starting voice "Welcome to..." is not played with original code.

This technique is used for playing PCM sounds on SSG/PSG by controling volume by CPU in retro PC and chiptune scene.
Also HW envelopes can be used for playing triangle wave and saw wave.

One of the another reference on twitter (in Japanese) is:
https://twitter.com/gorry5/status/1132210257642397696
https://twitter.com/gorry5/status/1132229707456401408/photo/1
You can see the DC output from the chip.

@aaronsgiles
Copy link
Owner

Thanks for the reference. Your implementation also agrees with MAME's AY-8910, so I believe it.

@aaronsgiles aaronsgiles merged commit dc253c9 into aaronsgiles:main Apr 16, 2022
@hyano hyano deleted the topic/ssg_mixer_disabled branch April 17, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants