Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues with the markup of the index.html #98

Closed
rpkoller opened this issue Apr 17, 2020 · 2 comments
Closed

A few issues with the markup of the index.html #98

rpkoller opened this issue Apr 17, 2020 · 2 comments
Assignees

Comments

@rpkoller
Copy link
Contributor

Hi I've taken a brief first look at the markup and noticed a few issues and low hanging fruits in regards of html5 validity. I could create a quick pull request if you want to. The minor details I've noticed:

  • remove the two meta content lines
  <meta content="text/html;charset=utf-8" http-equiv="Content-Type">
  <meta content="utf-8" http-equiv="encoding">

and replace that with the best practice of

<meta charset="utf-8">

and position it right before the title element (see https://htmlhead.dev)

  • move the twitter card as well as the open graph meta data to the head element
  • remove the two closing tags of img elements for the two logos

best regards ralf

@aatishb
Copy link
Owner

aatishb commented Apr 18, 2020

Hi @rpkoller, this sounds great to me, I'd welcome a PR for these. Thanks for looking into this!

@aatishb
Copy link
Owner

aatishb commented Apr 19, 2020

Merged. Thanks @rpkoller.

@aatishb aatishb closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants