Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fundamental bug in the offline repository #52

Closed
tdybda17 opened this issue Apr 30, 2020 · 1 comment
Closed

Fundamental bug in the offline repository #52

tdybda17 opened this issue Apr 30, 2020 · 1 comment

Comments

@tdybda17
Copy link
Contributor

tdybda17 commented Apr 30, 2020

Describe the bug
Models are stored in plain .json format in the offline repository which can produce unexpected behavior when reference models are updated or deleted.

Say an Activity with offline_id = 45 is saved in the offline repository with a pictogram with offline_id = 34:

{
    "id": "1",
    "order": "20",
    "pictogram": {
        "id": "2"
    }
}

If then the pictogram were to be deleted with

PictogramModel.offline().delete(34)

Then calling ActivityModel.offline().get(45) will still return the activity with the deleted picogram.

To Reproduce
Steps to reproduce the behavior:

  1. Insert an activity to the repository
  2. Delete its pictogram
  3. Get the activity again
  4. Notice that the pictogram is still there

Expected behavior
Activity should not get the deleted pictogram with it.

Actual behavior
Activity gets the deleted pictogram with it.

@tdybda17 tdybda17 added the type: bug Something isn't working label Apr 30, 2020
@dkalaxdk dkalaxdk added this to Highest in RAW_Product Backlog Sep 24, 2020
@Kaliahh Kaliahh added this to the 2020eS1 milestone Sep 30, 2020
@Determinatoro Determinatoro added this to Issues to do in 2020e 1. sprint Oct 5, 2020
@Kaliahh Kaliahh modified the milestones: 2020eS1, 2020eS2 Oct 27, 2020
@Determinatoro Determinatoro added this to Issues in progress in 2020e 2. sprint Oct 27, 2020
@Determinatoro Determinatoro moved this from Issues to do to Issues in progress in 2020e 1. sprint Oct 28, 2020
@puchasa puchasa removed this from Issues in progress in 2020e 1. sprint Oct 29, 2020
@Kaliahh Kaliahh added this to Issues to do in 2020e 1. sprint via automation Oct 29, 2020
@Kaliahh Kaliahh moved this from Issues in progress to Issues to do in 2020e 2. sprint Oct 29, 2020
@Kaliahh Kaliahh moved this from Issues to do to Issues in progress in 2020e 2. sprint Oct 29, 2020
@Kaliahh Kaliahh moved this from Issues to do to Issues in progress in 2020e 1. sprint Oct 29, 2020
@Riasalit
Copy link
Contributor

This issue does not exist anymore as all previous offline functionality was removed by 2020f

2020e 2. sprint automation moved this from Issues in progress to Issues done Nov 12, 2020
@Kaliahh Kaliahh removed this from Highest in RAW_Product Backlog Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2020e 1. sprint
  
Issues in progress
2020e 2. sprint
  
Issues done
Development

No branches or pull requests

5 participants