Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pictogram folder locally, when running the Docker environment. #381

Open
JMyrtue opened this issue Dec 12, 2023 · 0 comments
Open

Comments

@JMyrtue
Copy link
Contributor

JMyrtue commented Dec 12, 2023

Description

When seeding the database, a local pictogram folder is created, however, when it is run through the new Docker functionality, the pictogram folder is created in the docker environment, and not locally, which means that few integration tests fails, as they are dependent on the local pictogram folder.
Furthermore, it is likely that any request to the web-api that relates to pictograms either does nothing or crashes the web-api.

The quick-fix currently used, is that all pictograms are added to GitHub, thereby ensuring the folder i present after the repository have been cloned, however, arguably it would be preferred to not upload all pictograms to GitHub.

Possible Suggested Solution

  • Find a solution to creating the folder locally, when running the Docker environment.
  • Re-add that pictograms are ignored on pull requests in the .gitignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant