Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don´t know what HugeBase64Images.cs is used for #46

Closed
joandrsn opened this issue Feb 26, 2020 · 1 comment · Fixed by #65
Closed

Don´t know what HugeBase64Images.cs is used for #46

joandrsn opened this issue Feb 26, 2020 · 1 comment · Fixed by #65
Assignees
@mathiasandresen
Labels
priority: low
Projects
2020f 1. sprint
Milestone
2020S1

Comments

@joandrsn
Copy link
Contributor

I don't understand what it's there for anymore. As I see it, it has no references, and simply contains 66K characters.

It could possibly be one large image or many small images.

It's located in HugeBase64Images.cs (GirafRest/Data/HugeBase64Images.cs).

To quote the code:

/*
 * Beware ye who enters.
 *
 * Here be very long lines.
 */
@Lortemanden Lortemanden changed the title Do something about HugeBase64Images.cs Don´t know what HugeBase64Images.cs is used for Mar 9, 2020
@Lortemanden Lortemanden added this to To do in 2020f 1. sprint via automation Mar 9, 2020
@Lortemanden Lortemanden added this to the 2020S1 milestone Mar 9, 2020
@Lortemanden
Copy link
Contributor

Figure out what HugeBase64Images.cs is used for and document it in the readme. If it is not used remove it

@Lortemanden Lortemanden moved this from To do to Issues in progress in 2020f 1. sprint Mar 12, 2020
@mathiasandresen mathiasandresen self-assigned this Mar 17, 2020
@mathiasandresen mathiasandresen mentioned this issue Mar 17, 2020
Merged
2020f 1. sprint automation moved this from Issues in progress to Done Mar 17, 2020
2020f 1. sprint automation moved this from Done to Pull request in progress Mar 24, 2020
2020f 1. sprint automation moved this from Pull request in progress to Done Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathiasandresen mathiasandresen

Labels
priority: low
Projects
No open projects
2020f 1. sprint
  
Issues done
Milestone
2020S1
Development

Successfully merging a pull request may close this issue.

Fixes 46 aau-giraf/web-api
4 participants
@joandrsn @mathiasandresen @mads-bo @Lortemanden