Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I would like the table Pictograms to not include ImageHash. #47

Closed
Badgie opened this issue Feb 26, 2020 · 2 comments
Closed

Comments

@Badgie
Copy link
Contributor

Badgie commented Feb 26, 2020

Is your feature request related to a problem?
The Pictogram table in the database has an attribute ImageHash that is unused in the code (sans assignments in on the object). It is also merely the same hard coded string "Secure Hash" on almost every row.

Describe the solution you'd like
I would like for the table to be altered to remove the column.

Describe alternatives you've considered
Ignoring the problem, but it can cause confusion for the developer.

Additional context
Sample data as seen from MySQL. Please note that "Secure Hash" is the literal string Secure Hash and not a placeholder.

mysql> SELECT * FROM Pictograms LIMIT 5;
+----+-------------+----------------------------+-------+---------+-------------+
| id | AccessLevel | LastEdit                   | Sound | Title   | ImageHash   |
+----+-------------+----------------------------+-------+---------+-------------+
|  1 |           1 | 2017-05-26 14:53:00.660175 | NULL  | Epik    | 791559      |
|  2 |           1 | 2014-05-14 06:20:18.000000 | NULL  | alfabet | Secure Hash |
|  3 |           1 | 2014-05-14 06:20:18.000000 | NULL  | alle    | Secure Hash |
|  4 |           1 | 2014-05-14 06:20:18.000000 | NULL  | alting  | Secure Hash |
|  5 |           1 | 2014-05-14 06:20:19.000000 | NULL  | antal   | Secure Hash |
+----+-------------+----------------------------+-------+---------+-------------+

Additionally, when a new pictogram is saved to the database, the hash is simply computed using the built-in system method GetHashCode(). This gets the hash of the object in memory on the web-api. It makes NO sense to save this to the database.

@Lortemanden
Copy link
Contributor

I don't get what the problem is and what you would like to be done to fix this problem?

@joandrsn joandrsn changed the title Deprecate ImageHash from Pictos As a developer, I would like the table Pictograms to not include ImageHash. May 14, 2020
@Kaliahh Kaliahh added this to Not prioritized in RAW_Product Backlog Sep 28, 2020
@Kaliahh Kaliahh moved this from Not prioritized to Info needed (Not prioritised) in RAW_Product Backlog Oct 1, 2020
@soenderby
Copy link
Contributor

This is made irrelevant by #159

@Kaliahh Kaliahh removed this from Info needed (Not prioritised) in RAW_Product Backlog Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants