Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity timer disappears after modifying a weekplan #98

Closed
MathiasKRasmussen opened this issue Apr 21, 2020 · 1 comment · Fixed by #141
Closed

Activity timer disappears after modifying a weekplan #98

MathiasKRasmussen opened this issue Apr 21, 2020 · 1 comment · Fixed by #141
Labels
priority: high type: bug Something isn't working
Milestone

Comments

@MathiasKRasmussen
Copy link

MathiasKRasmussen commented Apr 21, 2020

Describe the bug
When a timer(s) have been added to activities in a week plan, the timer(s) are deleted and sometimes the activity too when you do one of the following actions:

  • The weekplan is edited (e,g, renamed)
  • A new activity is added
  • Reordering any activities
  • Canceling a activity and then click "Fortryd"
  • Copying an activity
  • Deleting an activity
  • Cancelling an activity from the weekplan screen

To Reproduce
Steps to reproduce the behavior:

  1. Go to any weekplan
  2. Click on an activity
  3. Add a timer
  4. Go back to the weekplan screen
  5. Do one of the listed actions that creates the bug
  6. See the timer(s) and the timer icon(s) disappear

Expected behavior
The activities with a timer before performing one of the actions should also have the timer afterwards

Actual behavior
The timer is not in the database after performing one of the actions

Additional context

  • We know that the timers are not deleted when cancelling an activity from the activity screen
  • All the actions that creates the bug calls the update method from the WeekApi class in the api-client (can be found in week_api.dart) These actions are also the only ones who call this method
  • The update method sends a json string and receives a new json string
    • The json string that is send has the timer information, but the json string received has the timer(s) as null
@Lortemanden
Copy link
Contributor

Lortemanden commented May 1, 2020

Solving this issue might also solve issue #112, aau-giraf/weekplanner#352 and aau-giraf/weekplanner#444

@T-Dawq T-Dawq removed the Gruppe 16 label May 5, 2020
@T-Dawq T-Dawq added this to the 2020S3 milestone May 5, 2020
@T-Dawq T-Dawq added this to Issues to do in 2020f 3. sprint via automation May 5, 2020
@Nannanas Nannanas moved this from Issues to do to Issues in progress in 2020f 3. sprint May 6, 2020
@pegede17 pegede17 mentioned this issue May 13, 2020
@pegede17 pegede17 linked a pull request May 13, 2020 that will close this issue
2020f 3. sprint automation moved this from Issues in progress to Issues done May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: bug Something isn't working
Projects
No open projects
2020f 2. sprint
  
Issues to do
2020f 3. sprint
  
Issues done
Development

Successfully merging a pull request may close this issue.

6 participants