Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a guardian i want the timer's play-button to function as a restart-button when the timer has finished #307

Closed
T-Dawq opened this issue Feb 26, 2020 · 1 comment · Fixed by #344
Labels
Priority: medium Medium priority, it's neither high nor low priority Type: refactor Restructuring existing code without changing its external behavior
Milestone

Comments

@T-Dawq
Copy link

T-Dawq commented Feb 26, 2020

Is your feature request related to a problem? Please describe.
When the timer has finished counting down, the pause symbol is still displayed on the play/pause-button. If it is pressed, the play symbol is displayed. Press it again and the symbol switches to the pause symbol but nothing happens with the timer.

Describe the solution you'd like
When the timer has finished, the pause symbol should automatically switch to a play symbol on the play/pause-button. When the button is pressed, a popup window should appear to confirm that the timer should be restarted. If restart is confirmed then the timer should be restarted, else the timer should remain as it was. You may have to pay attention to how this interacts with the ding sound (see comment by jbjarn17 below).

Describe alternatives you've considered
An alternative could be to simply remove the play/pause-button when the timer finishes.

Prototypes
See images or video demonstration in zip.
RestartButtonPrototype.zip
RestartButtonPrototype1
RestartButtonPrototype2

@T-Dawq T-Dawq added Type: bug Bugs and other insects Priority: medium Medium priority, it's neither high nor low priority labels Feb 26, 2020
@holyfailer holyfailer added the Prototype needed PO should create a prototype to ensure clarity label Feb 27, 2020
@jbjarn17
Copy link
Contributor

jbjarn17 commented Mar 4, 2020

I have noticed that after the ding sound has been attached to the timer(issue #264, pr #312) that the sound plays again if you push the play/pause button after the timer has finished.

@T-Dawq T-Dawq changed the title When timer has finished, the play/pause button behaves as if timer is still running. As a guardian i want the timer's play-button to function as a restart-button when the timer has finished Mar 9, 2020
@T-Dawq T-Dawq added Type: refactor Restructuring existing code without changing its external behavior and removed Type: bug Bugs and other insects labels Mar 9, 2020
@Lortemanden Lortemanden added this to To do in 2020f 1. sprint via automation Mar 9, 2020
@Lortemanden Lortemanden added this to the 2020S1 milestone Mar 9, 2020
@T-Dawq T-Dawq removed the Prototype needed PO should create a prototype to ensure clarity label Mar 11, 2020
@Lortemanden Lortemanden moved this from To do to Issues in progress in 2020f 1. sprint Mar 12, 2020
@MrPekar98 MrPekar98 mentioned this issue Mar 20, 2020
@antonhpalmer antonhpalmer linked a pull request Mar 23, 2020 that will close this issue
2020f 1. sprint automation moved this from Issues in progress to Issues done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: medium Medium priority, it's neither high nor low priority Type: refactor Restructuring existing code without changing its external behavior
Projects
No open projects
2020f 1. sprint
  
Issues done
Development

Successfully merging a pull request may close this issue.

4 participants