Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for pictogram_bloc API #604

Closed
Mustafa-ALD opened this issue Oct 14, 2020 · 0 comments
Closed

Error handling for pictogram_bloc API #604

Mustafa-ALD opened this issue Oct 14, 2020 · 0 comments
Labels
Priority: high High priority, its required to work Type: refactor Restructuring existing code without changing its external behavior

Comments

@Mustafa-ALD
Copy link
Contributor

Mustafa-ALD commented Oct 14, 2020 •
edited

Is your feature request related to a problem? Please describe.
This task is related to issue #431.

Describe the solution you'd like
As described in #431 there should be error/exception handling for the API call.
Avoid try-catch because it will delay UI.
Context:

weekplanner/lib/blocs/pictogram_bloc.dart

Lines 60 to 65 in ef1da3a

_api.pictogram
.getAll(page: 1, pageSize: 10, query: query)
.listen((List<PictogramModel> results) {
_resultPlaceholder = results;
_pictograms.add(_resultPlaceholder);
});

Additional context
Original request of refactoring: #431
@Mustafa-ALD Mustafa-ALD added Type: refactor Restructuring existing code without changing its external behavior Not prioritised Minor issues or features which are not a requirement labels Oct 14, 2020
@Mustafa-ALD Mustafa-ALD mentioned this issue Oct 15, 2020
Open
@Kaliahh Kaliahh added this to Not prioritised in RAW_Product Backlog Oct 15, 2020
@Kaliahh Kaliahh removed this from Not prioritised in RAW_Product Backlog Oct 15, 2020
@Kaliahh Kaliahh added this to Not prioritised in RAW_Product Backlog Oct 19, 2020
@Kaliahh Kaliahh added Priority: high High priority, its required to work and removed Not prioritised Minor issues or features which are not a requirement labels Oct 19, 2020
@Kaliahh Kaliahh moved this from Not prioritised to High in RAW_Product Backlog Oct 19, 2020
@Kaliahh Kaliahh removed this from High in RAW_Product Backlog Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: high High priority, its required to work Type: refactor Restructuring existing code without changing its external behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kaliahh @Mustafa-ALD