Exception when deserializing an interface

[etki]

YamlDotNet tries to get generic reflection on an interface that is not guaranteed to be generic:

    public sealed class DefaultObjectFactory : IObjectFactory
        //...
        public object Create(Type type)
        {
            if (type.IsInterface())
            {
                if (defaultInterfaceImplementations.TryGetValue(type.GetGenericTypeDefinition(), out var implementationType))
                {
                    type = implementationType.MakeGenericType(type.GetGenericArguments());
                }
            }

YamlDotNet/YamlDotNet/Serialization/ObjectFactories/DefaultObjectFactory.cs

Line 44 in b3cf637

if (defaultInterfaceImplementations.TryGetValue(type.GetGenericTypeDefinition(), out var implementationType))

Trace:

System.InvalidOperationException: This operation is only valid on generic types.
   at System.RuntimeType.GetGenericTypeDefinition()
   at YamlDotNet.Serialization.ObjectFactories.DefaultObjectFactory.Create(Type type)
   at YamlDotNet.Serialization.NodeDeserializers.ObjectNodeDeserializer.YamlDotNet.Serialization.INodeDeserializer.Deserialize(IParser parser, Type expectedType, Func`3 nestedObjectDeserializer, Object& value)
   at YamlDotNet.Serialization.ValueDeserializers.NodeValueDeserializer.DeserializeValue(IParser parser, Type expectedType, SerializerState state, IValueDeserializer nestedObjectDeserializer)

[aaubry]

You're right. I should fix that. Thanks for reporting!