Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed dlls required #687

Closed
abebube opened this issue Apr 29, 2022 · 4 comments
Closed

Signed dlls required #687

abebube opened this issue Apr 29, 2022 · 4 comments

Comments

@abebube
Copy link

abebube commented Apr 29, 2022

My team uses this package to convert c# objects to yaml.

However, we need a signed version of YamlDotNet.dll.
The nuget package is signed but the actual dll isn't signed, and this is triggering violations on our end.

Could we have this update?

@aaubry
Copy link
Owner

aaubry commented Apr 29, 2022

Which version are you using? I've checked the latest package and all the libraries are signed.

image

Notice that the key used to sign these packages is public, which means that anyone can produce a modified version of the library and sign it. This signature is just a convenience for users requiring a strong named assembly.

@abebube
Copy link
Author

abebube commented Apr 29, 2022

The version is the current latest: 11.2.1

I'm actually referring to the digital signature of the .dll contained in the package.

See side-by-side of yamldotnet dll and a signed dll:
image

@aaubry
Copy link
Owner

aaubry commented Apr 29, 2022

The only signature that is provided is the .NET assembly signature, which is the standard practice in the .NET world, as far as I can tell. I suggest that you setup your own CI pipeline to sign the dlls yourself. The build should be easy to replicate. You can base yourself on appveyor.yml.

@EdwardCooke
Copy link
Collaborator

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants