Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: defend against zip bombs. #407

Merged
merged 1 commit into from
May 20, 2018
Merged

Security fix: defend against zip bombs. #407

merged 1 commit into from
May 20, 2018

Conversation

aaugustin
Copy link
Member

@aaugustin aaugustin commented May 19, 2018

websockets 4.0 was vulnerable to denial of service by memory exhaustion because it didn't enforce max_size when decompressing compressed messages.

@aaugustin
Copy link
Member Author

I'm requesting a CVE for this issue.

@codecov
Copy link

codecov bot commented May 19, 2018

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #407   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          29     29           
  Lines        3159   3170   +11     
  Branches      332    333    +1     
=====================================
+ Hits         3159   3170   +11
Impacted Files Coverage Δ
websockets/framing.py 100% <100%> (ø) ⬆️
websockets/extensions/base.py 100% <100%> (ø) ⬆️
websockets/extensions/test_permessage_deflate.py 100% <100%> (ø) ⬆️
websockets/extensions/permessage_deflate.py 100% <100%> (ø) ⬆️
websockets/test_framing.py 100% <100%> (ø) ⬆️
websockets/test_client_server.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b89213...5b96bdc. Read the comment docs.

@aaugustin
Copy link
Member Author

I reached out by email to maintainers of competing libraries which appear to be vulnerable to the same issue. (Not going to provide a list who for obvious reasons.)

@aaugustin
Copy link
Member Author

Same fix in Tornado: tornadoweb/tornado#2391

@abergmann
Copy link

CVE-2018-1000518 was assigned to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants