Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartitionedSMatrix has no ._generate_probes() method #84

Open
hisigns opened this issue Jun 25, 2022 · 2 comments
Open

PartitionedSMatrix has no ._generate_probes() method #84

hisigns opened this issue Jun 25, 2022 · 2 comments

Comments

@hisigns
Copy link

hisigns commented Jun 25, 2022

I am running a simulation that is too big to fit in memory so I used the num_partitions=2 flag while creating my SMatrix array. When I try and use the S.scan method I get something similar to the error in the title: PartitionedSMatrix has no ._generate_probes() method.

I am not sure if I am setting up the PartitionedSMatrix object and scan correctly - Here are my current inputs:
Screenshot from 2022-06-24 22-47-09
Screenshot from 2022-06-24 22-48-04

I looked into where the error was showing up and added some print statements to see what kind of object, "S" ,( an SMatrix or PartitionedSMatrix) was being referenced in each step. For the 3 print statements shown below all "S" are PartitionedSMatrix objects.

Screenshot from 2022-06-24 22-36-44

But I can't find a _generate_probes() method in the PartitionedSMatrix class.

@jacobjma
Copy link
Member

I am afraid I never fully finished the implementation of the partitioned PRISM algorithm in the current main branch. I have continued working on the implementation in the abtem-dask branch. However, because no one (until now), has expressed interest in using the algorithm, it has not been prioritized.

I will update this issue when it is available. It is pretty close to finished, so maybe I have time to finish it this week.

@TomaSusi
Copy link
Member

Can we close this, @jacobjma ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants